ahmadsamir added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in runnermodel.cpp:179
> Here should be `m_runners = runners` to be exactly same as previous. I don't 
> see much benefit of having duplicate items.

IIUC, the original code used toSet() to remove duplicates from both "m_runners" 
and "runners", because QSet doesn't allow duplicate items.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to