gikari added inline comments.
INLINE COMMENTS
> CMakeLists.txt:22
> +pkg_check_modules(GIO REQUIRED IMPORTED_TARGET gio-2.0)
> +pkg_check_modules(giomm REQUIRED IMPORTED_TARGET giomm-2.4)
> +
If I understand correctly this line is redundant.
> CMakeLists.txt:7
> target_compile_definitions(gtk_preview PRIVATE
> "-DDATA_DIR=\"${KDE_INSTALL_FULL_DATADIR}/kcm-gtk-module/\"")
> -target_link_libraries(gtk_preview ${GTK2_LIBRARIES} ${GTK2_GIOMM_LIBRARY})
> +target_link_libraries(gtk_preview PkgConfig::GTK+2 PkgConfig::giomm)
> install(TARGETS gtk_preview RUNTIME DESTINATION "${LIBEXEC_INSTALL_DIR}")
And `PkgConfig::giomm` is redundant too.
REPOSITORY
R99 KDE Gtk Configuration Tool
REVISION DETAIL
https://phabricator.kde.org/D28086
To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
