ahiemstra added inline comments.

INLINE COMMENTS

> zzag wrote in screencaststream.cpp:549-563
> Do we actually need an fbo?

The entire framebuffer is superfluous, it is never used. glGetTexImage() reads 
from the currently bound texture, which in this case is "texture" since you 
bind it at line 546.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28272

To: jgrulich, #plasma, zzag
Cc: ahiemstra, meven, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to