On May 22, 2010 09:03:53 Alessandro Diaferia wrote: > Hullo, > it seems reviewboard cannot connect to anonsvn (at least from here) so i'm > attaching the patch here as it is really small. > > Having a look at https://bugs.kde.org/show_bug.cgi?id=231791 you can see > how easy is reproducing the bug. > It seems that kickoff does not allow adding favorites via D&D. D&D is only > used to move items in the list. > This little patch allows adding favorites via D&D dragging from the > application view to the favorites one. > I just don't know if this is considered as a new feature. It seems to me > that this patch just makes kickoff behaving as it is expected to behave. > > Anyway the last word is yours of course, plasma-friends :) > > Regards.
hmm. no comment on whether it's a feature.. code looks sensible, although wouldn't it be more future-proof to iterate over data->urls() instead of only taking the first? -- This message brought to you by eevil bananas and the number 3. www.chani3.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
