broulik added a comment.
> Should compile and work exactly as before. Please always test `QRegularExpression` migration, I've seen just too many regressions when this wasn't done carefully INLINE COMMENTS > firefox.cpp:171 > + /* This allows the user to specify a profile database */ > + m_dbFile = grp.readEntry<QString>("dbfile", QString()); > + if (m_dbFile.isEmpty() || !QFile::exists(m_dbFile)) { The default argument is sufficient to resolve the type, `readEntry("foo", QString())` is enough REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28473 To: alex, bruns, broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart