mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > broulik wrote in CategoriesPage.qml:207 > `Kirigami.Units.iconSizes.small` and elsewhere > > Why do you need this wrapper `Item`, though? try to keep the item count as small as possible, especially in item delegates. I would really prefer if we could do without this wrapper > SubCategoryPage.qml:198 > + > + width: 16 > + height: 16 width: Kirigami.Units.iconSizes.small REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart Cc: mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra