fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  I can't find a better way to do this either...
  
  Some notes:
  
  - `window.eval` works as expected so if not entirely unlucky (old firefox?) 
this can be replaced by using `executeScript` completely (PR incoming)
  - On chrome it works by accident as `window.Audio.prototype` is `Object`. 
`exportFunction` seems to clean that up, presumably to prevent access to the 
content script's `Object` (which != `window.Object`...)
  
  So I'm wondering whether the other overrides should also set the protoype 
properly? Currently `window.Audio.prototype != Audio` on non-firefox.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28706

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to