----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4154/ -----------------------------------------------------------
Review request for Plasma and Aaron Seigo. Summary ------- This patch makes use of KCModuleProxy class and embeds the virtual desktops KCM directly into the pager configuration dialog, removing the "Configure desktops" button. Diffs ----- /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/CMakeLists.txt 1130818 /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.h 1130818 /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp 1130818 /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pagerConfig.ui 1130818 Diff: http://reviewboard.kde.org/r/4154/diff Testing ------- There is a strange problem. Wheh I build it on my machine, if I press OK in the embedded KCM after changging something in it, Plasma quits. No crash, just quits. Marco Martin has applied the patch and he has no such problem. Please investigate. Until solved this request is a draft. Thanks, Ignat _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
