z3ntu planned changes to this revision. z3ntu added inline comments. INLINE COMMENTS
> nicolasfella wrote in config.cpp:99 > That sounds like a job for std::all_of I wasn't aware that C++ had such fancy methods :) I'm using equivalent functions a lot in Kotlin but they are honestly much nicer to use in Kotlin than in C++. In this case instead of the "continue" keyword I would have to return true then I guess. > romangg wrote in config.cpp:104 > Should we check if all or only one panel display are set to auto rotate. > Granted I'm not aware of a device with multiple panel displays which runs > KScreen but maybe you had a reason for using && here? > > Just want to hear a rational if you had one. If you didn't and just picked && > by random it's also fine. I thought it makes more sense to say "auto rotate is enabled when all panels have auto rotate enabled" rather than "auto rotate is enabled when at least one panel has auto rotate enabled" which is why I've chosen to do it this way. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28773 To: z3ntu, #plasma, bshah Cc: romangg, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
