fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Just have to make sure not to add anything to 
`DEFAULT_EXTENSION_SETTINGS.mpris.websiteSettings` now. Previously that 
would've been ignored.

INLINE COMMENTS

> utils.js:39
> +                    Object.keys(add).forEach((key) => {
> +                        if (!obj.hasOwnProperty(key)) {
> +                            obj[key] = add[key];

Why not if/else?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28791

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to