ngraham added a comment.
This is looking really good. Other than my previous comments (most of which
have been resolved, yay) I have just nitpicks left, really.
INLINE COMMENTS
> ShortcutActionDelegate.qml:165
> + onClicked:
> kcm.shortcutsModel.disableShortcut(originalIndex, modelData)
> + QQC2.ToolTip {
> + text: i18n("Delete this shortcut")
This tooltip is not working for me
> shortcutsmodel.cpp:165
> +
> +void ShortcutsModel::defaults() {
> + for (auto& component : m_components) {
Clicking the Defaults button does not seem to have any effect for me
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D28744
To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel,
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, ahiemstra, mart
