dfaure added a comment.
The unittest in this commit appears to break in CI. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kirigami/job/kf5-qt5%20SUSEQt5.12/417/testReport/junit/projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512/autotests/tst_pagerouter_qml/ PASS : Kirigami::PageRouterGeneralTests::test_50_push() PASS : Kirigami::PageRouterGeneralTests::test_60_pop() QWARN : Kirigami::PageRouterGeneralTests::test_70_bring_to_view() Route "login" with data QVariant(QString, "red") is not on the current stack of routes. FAIL! : Kirigami::PageRouterGeneralTests::test_70_bring_to_view() Compared values are not the same Actual (): 0 Expected (): 1 Loc: [/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/autotests/tst_pagerouter.qml(38)] FAIL! : Kirigami::PageRouterGeneralTests::test_80_routeactive() Compared values are not the same Actual (): false Expected (): true Loc: [/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/autotests/tst_pagerouter.qml(45)] PASS : Kirigami::PageRouterGeneralTests::test_90_initial_route() Please investigate and fix. Thanks! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28383 To: cblack, #kirigami, mart, davidedmundson Cc: dfaure, ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, mart
