jgrulich accepted this revision.
jgrulich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:39
> +        Controls.Switch {
> +            id: enabled
> +            Kirigami.FormData.label: i18n("Enabled:")

Using adjective as an ID looks weird to me.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to