dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > server.cpp:134 > + for ( int i=1; i < n; i++) > + argList.append( command[i]); > + auto *job = new KIO::CommandLauncherJob(app, argList); (pre-existing) argList = command; argList.removeFirst(); would be simpler and faster. > server.cpp:137 > + job->start(); > + return; > } This return statement serves no purpose. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29226 To: broulik, #plasma, dfaure Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
