broulik added a subscriber: dfaure. broulik added inline comments. INLINE COMMENTS
> DeviceItem.qml:32 > > -MouseArea { > +// TODO: fix expanding when a new device is connected; done in > devicenotifier.qml > +// TODO: clean up list item expanding code in devicenotifier.qml There's an `expandedDevice` property in devicenotifier.qml which is supposed to decide which device is expanded. You either want to wire up this properly with the new delegate or nuke it. For example in `DeviceItem` do Connections { target: devicenotifier onExpandedDeviceChanged: { if (devicenotifier.expandedDevice === udi) { deviceItem.expand(); } else { deviceItem.collapse(); } } } However, it resets the `expandedDevice` right away for whatever reason. But this should maybe give you an idea. Alternatively, since expanded state is now in the delegate, you could just emit a signal when a source is added to have the device expand. > DeviceItem.qml:34 > +// TODO: clean up list item expanding code in devicenotifier.qml > +// TODO: make the free space calculation/display work again for > newly-mounted volumes > +// TODO: make sure message display works This is all over the place for me. All the free space jobs in the dataengine get the root size back. Not sure if a local issue or KIO? @dfaure REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28321 To: ngraham, #vdg, #plasma, broulik Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart