bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed.
The summary needs some text which works without any images The code needs some comment which tells how the selection logic works and why it is as it is. INLINE COMMENTS > firefox.cpp:184 > } else { > - // There are multiple profiles, find the default one > + const QStringList installConfig = > firefoxProfile.groupList().filter(QRegularExpression("Install.*")); > + if (installConfig.size() == 1) { Missing start of string anchor (^) > firefox.cpp:185 > + const QStringList installConfig = > firefoxProfile.groupList().filter(QRegularExpression("Install.*")); > + if (installConfig.size() == 1) { > + profilePath = > firefoxProfile.group(installConfig.first()).readEntry("Default"); Can this ever be > 1? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29326 To: alex, #plasma, ngraham, bruns, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart