----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4252/#review6028 -----------------------------------------------------------
Correct me if I missed anything, but as I skimmed through the diff, it looked to me that this is only about Nepomuk tags. Correct? I may be splitting hairs here, but when I hear "tag editing" in the context of media players, I think of ID3 tags and such. - Markus On 2010-06-07 21:43:23, Christophe Olinger wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4252/ > ----------------------------------------------------------- > > (Updated 2010-06-07 21:43:23) > > > Review request for Plasma and Alessandro Diaferia. > > > Summary > ------- > > This patch introduces a new label in the bottom bar. When playing/looking at > a media file, it displays its tags. When clicking on the label, the user can > add/edit tags to an item. When multiple items are selected, tags are applied > to all of them. > > P.S. The videostate.cpp contains comments. > > > Diffs > ----- > > > trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h > 1135632 > > trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.cpp > 1135632 > > trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.h > 1135632 > > trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/musicstate.cpp > 1135632 > > trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.h > 1135632 > > trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/picturestate.cpp > 1135632 > > trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.h > 1135632 > > trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/videostate.cpp > 1135632 > > trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediacenter/mainwindow.cpp > 1135632 > > Diff: http://reviewboard.kde.org/r/4252/diff > > > Testing > ------- > > Adding, editing tags was tested extensively. No more bugs should remain (TM) > > > Thanks, > > Christophe > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
