davidedmundson added inline comments. INLINE COMMENTS
> kstart.cpp:121 > + } else { > + printf("%d\n", job->pid()); > + } I know it's copied but, there's no need to randomly go to C to use std::cout > kstart.cpp:128 > + if (job->error()) { > + KStartupInfo::sendFinish( id ); // failed to start > + } else { Isn't command launcherjob doing KStartupInfo things? REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D29621 To: broulik, #plasma, dfaure Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart