alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision.
REVISION SUMMARY The copying/updating of the cache has been removed from the FetchSqlite class. This allows the browsers to have handle the caching differently. The firefox sqlite files are only copied if they changed. Before they were copied for each match session. The default behaviour for chrome is keept (for now). TEST PLAN Shows icons for results. Add new bookmarks, close browser, the new bookmarks should show up with icons. REPOSITORY R120 Plasma Workspace BRANCH avid_unnecessary_copying (branched from master) REVISION DETAIL https://phabricator.kde.org/D29726 AFFECTED FILES runners/bookmarks/browsers/firefox.cpp runners/bookmarks/browsers/firefox.h runners/bookmarks/faviconfromblob.cpp runners/bookmarks/fetchsqlite.cpp runners/bookmarks/fetchsqlite.h To: alex Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart