Since commit f09b46bec639a97008f3471b4b9bf52648979d12 by Marco Martin titled "Draft: Replace QString cache IDs with a struct-based version" the CI says plasma-framework unittests don't pass anymore.
FAIL! : ThemeTest::loadSvgIcon() 'm_svg->theme()->findInCache(cacheId, result, info.lastModified().toSecsSinceEpoch())' returned FALSE. () Loc: [/home/jenkins/workspace/Frameworks/plasma-framework/kf5-qt5 SUSEQt5.14/autotests/themetest.cpp(81)] See https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.14/job/plasma-framework/job/kf5-qt5%20SUSEQt5.14/40/testReport/projectroot/autotests/plasma_themetest/ Could someone from the plasma team please keep an eye on unittests so I don't have to be the unittest police? Oh, and Kirigami has a broken unittest too: FAIL! : Kirigami::AvatarTests::test_bad_names() Uncaught exception: NameUtils is not defined Loc: [/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.14/autotests/tst_avatar.qml(38)] See https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.14/job/kirigami/job/kf5-qt5%20SUSEQt5.14/65/testReport/junit/projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514/autotests/tst_avatar_qml/ I think that one is for Carson Black, CC'ed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
