----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4519/#review6434 -----------------------------------------------------------
I wouldn't worry about the size just now, it can be done in a separate commit. I actually have a patch that adjusts the size based on the number of items, but I couldn't decide if I liked it or not. I think showing the information icon next to the text might be a bit too much though. /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <http://reviewboard.kde.org/r/4519/#comment6166> Does it still work if this is changed to if (m_model->rowCount() == 0 && !listingInProgress())? It would simplify the rest of the code a bit if it does. It should probably also be 'else if', so two messages aren't overlaid. - Fredrik On 2010-07-08 19:22:01, Iamluc wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4519/ > ----------------------------------------------------------- > > (Updated 2010-07-08 19:22:01) > > > Review request for Plasma. > > > Summary > ------- > > Hello, > > This patch add a Plasma::Label with text "This folder is empty." in > Folderview's Popup when the folder is empty. > > The related bug number in kde bugzilla is 201542. > > Luc > > > This addresses bug 201542. > https://bugs.kde.org/show_bug.cgi?id=201542 > > > Diffs > ----- > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1145373 > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1145373 > > Diff: http://reviewboard.kde.org/r/4519/diff > > > Testing > ------- > > Delete/add files several times. The label disappears/appears correctly. > > > Screenshots > ----------- > > folderview empty folder > http://reviewboard.kde.org/r/4519/s/444/ > version 2 > http://reviewboard.kde.org/r/4519/s/455/ > > > Thanks, > > Iamluc > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
