> On 2010-07-10 14:32:16, Marco Martin wrote: > > trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp, line 620 > > <http://reviewboard.kde.org/r/4537/diff/2/?file=30620#file30620line620> > > > > should change the widget ownership to TabBar and delete any old one > > that was already existing
Shouldn't the ownership be already taken by the layout? I don't think it should delete the old widget. If i was doing an applet with this i may want to have a "new tab" button only when the immutability is Mutable. And i don't think that deleting and recreating the widget again and again would be so clean. - Giulio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4537/#review6466 ----------------------------------------------------------- On 2010-07-10 14:26:41, Giulio Camuffo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4537/ > ----------------------------------------------------------- > > (Updated 2010-07-10 14:26:41) > > > Review request for Plasma and Marco Martin. > > > Summary > ------- > > This patch adds two methods that allow to put two QGraphicsWidget in the top > left and top right corner of the tab bar, like it is possible with QTabWidget. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 > trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 > > Diff: http://reviewboard.kde.org/r/4537/diff > > > Testing > ------- > > Tested, it works, but there's one thing that annoys me and I don't how to > solve in a clean way: when there are no tabs the NativeTabBar becomes a bit > smaller in height and the widgets resize accordingly. > > > Screenshots > ----------- > > added two Plasma::PushButton > http://reviewboard.kde.org/r/4537/s/446/ > > > Thanks, > > Giulio > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel