----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4676/ -----------------------------------------------------------
Review request for Plasma. Summary ------- Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on plasma-devel. The horizontal orientation behaved a bit strangely: AbstractIconList was becoming much larger than the screen width. I had to change the layout code to include the "Close" button inside FilteringWidget layout instead of creating another layout. Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider sizes. Diffs ----- trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h 1147944 trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp 1147944 trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h 1147944 trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp 1147944 trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 1147944 Diff: http://reviewboard.kde.org/r/4676/diff Testing ------- Tested in both horizontal and vertical modes, with lists larger and smaller than the view. Thanks, Aurélien
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
