----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review7175 -----------------------------------------------------------
/trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp <http://reviewboard.kde.org/r/4585/#comment7316> if the item is guaranteed to be a LauncherItem, just use a static_cast (faster than a qobject_cast, and doesn't imply that it might be something else) /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h <http://reviewboard.kde.org/r/4585/#comment7319> following the naming conventions: GroupItemType, LauncherItemType, TaskItemType /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp <http://reviewboard.kde.org/r/4585/#comment7320> const QString /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp <http://reviewboard.kde.org/r/4585/#comment7321> probably a bit faster to do: taskClass.compare(launcher->name(), Qt::CaseInsensitive) == 0 since that prevents a copy of the string being made. it would also make the above toLower() unnecessary. /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp <http://reviewboard.kde.org/r/4585/#comment7317> the result of qobject_cast isn't checked and the item is guaranteed to be a launcher, so a static_cast is enough (and faster) here /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp <http://reviewboard.kde.org/r/4585/#comment7318> the result of qobject_cast isn't checked and the item is guaranteed to be a launcher, so a static_cast is enough (and faster) here - Aaron On 2010-08-22 10:39:29, Anton Kreuzkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4585/ > ----------------------------------------------------------- > > (Updated 2010-08-22 10:39:29) > > > Review request for Plasma. > > > Summary > ------- > > Adds support for Windows 7 like launchers in libtaskmanager. > (I'm on holliday from 12th July until 1st August so I will not be able to > reply during this time.) > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION > /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATION > > /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp > 1148442 > > /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/kustodiangroupingstrategy.cpp > 1148442 > > /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/manualgroupingstrategy.cpp > 1148442 > > /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp > 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1148442 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1166310 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1166310 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1166310 > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.cpp 1148442 > > Diff: http://reviewboard.kde.org/r/4585/diff > > > Testing > ------- > > Tested with a small test-applett and everything works. > > > Thanks, > > Anton > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
