----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5320/#review7579 -----------------------------------------------------------
First of all, thanks for looking into this and most of all for submitting a patch. Unfortunately, just like Sebastian said, I'm afraid I'm not willing to let this patch in. However, in the upcoming solid sprint I plan to address this. Luckily, UPower has a signal which does exactly what you tried to achieve here. I will get in touch with you as soon as I will implement the needed part in PowerDevil/Solid so you can code another patch against the new method. How does this sound to you? - Dario On 2010-09-13 11:20:38, Björn Ruberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5320/ > ----------------------------------------------------------- > > (Updated 2010-09-13 11:20:38) > > > Review request for Plasma and Solid. > > > Summary > ------- > > NOTE: This a little bit ugly as I have to workaround the missing "going to > suspend"-signal in the linux userland > > This patch adds a signal to powerdevil that is emitted when a > suspend/hibernate/standby is requested there. The signal is caught by the > time engine what starts to look for an unexpected change in system time for > two minutes by polling. If a clock skrew is detected, all sources are updated > immediatly. > > This fixes the bug that the plasma clocks are showing old time after > suspending your machine up until 59 seconds (whenever the normal update is > scheduled). This is not exactly a patch for bug 181380. But the clock skrew > detection code can be used quite similar for detecting normal time changes. > I'll look into that as soon this is accepted. > > Please tell me whether I can commit this to 4.5 trunk as it is a bugfix for a > nasty glitch. > > > This addresses bug 181380. > https://bugs.kde.org/show_bug.cgi?id=181380 > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/time/timeengine.h > 1166313 > /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/time/timeengine.cpp > 1166313 > /trunk/KDE/kdebase/workspace/powerdevil/daemon/PowerDevilDaemon.h 1166313 > /trunk/KDE/kdebase/workspace/powerdevil/daemon/PowerDevilDaemon.cpp 1166313 > /trunk/KDE/kdebase/workspace/powerdevil/daemon/org.kde.PowerDevil.xml > 1166313 > > Diff: http://svn.reviewboard.kde.org/r/5320/diff > > > Testing > ------- > > Suspended machine, waited three minutes, woke up again - and noticed that all > clocks on screen showed the correct time almost immediatly :) > > > Thanks, > > Björn > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
