> On 2010-09-15 22:34:11, Sebastian Kügler wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/picture.h, line 66 > > <http://svn.reviewboard.kde.org/r/5362/diff/3/?file=35935#file35935line66> > > > > trailing whitespace, please remove
Noted down and removed the trailing white space. > On 2010-09-15 22:34:11, Sebastian Kügler wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp, line 90 > > <http://svn.reviewboard.kde.org/r/5362/diff/3/?file=35936#file35936line90> > > > > should probably be a bool Changed to bool. > On 2010-09-15 22:34:11, Sebastian Kügler wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp, line 132 > > <http://svn.reviewboard.kde.org/r/5362/diff/3/?file=35936#file35936line132> > > > > Don't use a magic string here, a bool looks more in place? Changed to bool. Hence m_checkDir = "Empty" changes to m_checkDir = false; - Sujith ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/#review7624 ----------------------------------------------------------- On 2010-09-16 03:54:44, Sujith H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5362/ > ----------------------------------------------------------- > > (Updated 2010-09-16 03:54:44) > > > Review request for Plasma. > > > Summary > ------- > > This diff will give the user meaningful message when a folder is dropped to > the frame applet and if it doesn't contain image(s). > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 > trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 > trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 > trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 > > Diff: http://svn.reviewboard.kde.org/r/5362/diff > > > Testing > ------- > > This has been tested. > > > Thanks, > > Sujith > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel