----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5451/#review7839 -----------------------------------------------------------
Ship it! a few small things, but this can go in with the details fixed :) trunk/KDE/kdelibs/plasma/corona.h <http://svn.reviewboard.kde.org/r/5451/#comment8108> should be marked with KDE_DEPRECATED to generate compiler warnings. trunk/KDE/kdelibs/plasma/corona.h <http://svn.reviewboard.kde.org/r/5451/#comment8109> KConfigGroup &config, same as elsewhere in the libplasma API. trunk/KDE/kdelibs/plasma/corona.cpp <http://svn.reviewboard.kde.org/r/5451/#comment8110> right now importLayout(const KConfigBase &conf) checks to make sure that the KConfigGroup isValid(); this check should be moved to CoronaPrivate::importLayout so it can be shared with both importLayout methods. - Aaron On 2010-09-27 14:38:42, Chani Armitage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5451/ > ----------------------------------------------------------- > > (Updated 2010-09-27 14:38:42) > > > Review request for Plasma. > > > Summary > ------- > > this adds exportLayout to corona, which saves a group of containments to a > config file and deletes them from the main config. > > Activity::close() becomes a lot shorter by calling it, like this: > m_corona->exportLayout(external, m_containments.values()); > > I feel a bit out of it today though, so tell me if I've missed anything > obvious... > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/corona.h 1179499 > trunk/KDE/kdelibs/plasma/corona.cpp 1179499 > > Diff: http://svn.reviewboard.kde.org/r/5451/diff > > > Testing > ------- > > closing an activity while locked is perfectly safe now :) > > > Thanks, > > Chani > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
