----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5465/#review7884 -----------------------------------------------------------
Ship it! looks good, though the patch looks like it hasn't been tidied up for commit yet. the code itself looks good, though, so just tidy it up and commit. nicely done! /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.h <http://svn.reviewboard.kde.org/r/5465/#comment8134> delete the line before committing :) /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp <http://svn.reviewboard.kde.org/r/5465/#comment8135> watch the whitespace :) /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp <http://svn.reviewboard.kde.org/r/5465/#comment8136> delete before commit - Aaron On 2010-09-28 10:01:19, Björn Ruberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5465/ > ----------------------------------------------------------- > > (Updated 2010-09-28 10:01:19) > > > Review request for Plasma. > > > Summary > ------- > > Patch fixes the bug that the mouse grab of the color-picker goes away when > the panel hides. The idea of initiating the grab not on the panel but on a > self created widget is from ksnapshot. > I want someone to look at it because I want to commit it KDE 4.5 branch as a > bugfix. > > > This addresses bug 252350. > https://bugs.kde.org/show_bug.cgi?id=252350 > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.h 1180054 > /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp 1180054 > > Diff: http://svn.reviewboard.kde.org/r/5465/diff > > > Testing > ------- > > Had kolourpicker in an autohiding panel - and it suddenly works. Tested with > an applet on the desktop too. Works. > > > Thanks, > > Björn > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
