> On 2010-10-06 12:45:50, Anne-Marie Mahfouf wrote: > > What's the use case for such an addition? > > > > The case that does not work in your patch is when you add 1 picture which > > is the same as a static picture but then you get the slideshow arrows. > > I am not very keen of adding code for new features without a good use case > > as it generates bugs and clutters the code (which happened a lot with this > > applet). > > > > It is understood that people will display all files from a folder in a > > slideshow (or from different folders) and if they don't want this picture > > they will remove it from the folder. If you want separate pictures from > > several folders, just copy them in a unique folder and point the slideshow > > to this folder. For consistency, the Desktop slideshow has no 'Add file' > > for example. > >
hm ... you are right, this patch could be confusing for users, I will discard it thanks - michal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/#review7995 ----------------------------------------------------------- On 2010-10-06 12:19:36, michal seben wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4256/ > ----------------------------------------------------------- > > (Updated 2010-10-06 12:19:36) > > > Review request for Plasma. > > > Summary > ------- > > This patch enhance slideshow in frame plasmoid, after applying user could add > separate pictures to slideshow. Currently slideshow could contain only (all) > files in chosen directories. > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1135431 > /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1135431 > /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1135431 > /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1135431 > /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1135431 > > Diff: http://svn.reviewboard.kde.org/r/4256/diff > > > Testing > ------- > > > Thanks, > > michal > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
