> On 2010-10-01 17:21:28, Aaron Seigo wrote: > > update to current trunk if needed, and let's get this in as well. > > Anselmo L. S. Melo wrote: > @agateau: I've updated this patch to current trunk [1] - I updated it > when I wrote another patch [2], to check if both patches were ok together. > Now it is an updated version on top of today's trunk =) > > [1] - > http://anselmolsm.org/public/kde/plasma-addwidget-scrollwidget-r1181856.diff > [2] - http://reviewboard.kde.org/r/5446/ > > Aurélien Gâteau wrote: > Sounds good, please commit your updated version if it's not already in > (/me needs to update his trunk checkout)
Ok, I'll commit tomorrow morning here (UTC-3) =) - Anselmo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4676/#review7930 ----------------------------------------------------------- On 2010-08-04 21:02:11, Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4676/ > ----------------------------------------------------------- > > (Updated 2010-08-04 21:02:11) > > > Review request for Plasma. > > > Summary > ------- > > Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on > plasma-devel. > > The horizontal orientation behaved a bit strangely: AbstractIconList was > becoming much larger than the screen width. I had to change the layout code > to include the "Close" button inside FilteringWidget layout instead of > creating another layout. > > Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar > slider sizes. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h > 1147944 > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp > 1147944 > > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h > 1147944 > > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp > 1147944 > > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h > 1147944 > > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp > 1147944 > > trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp > 1147944 > > Diff: http://svn.reviewboard.kde.org/r/4676/diff > > > Testing > ------- > > Tested in both horizontal and vertical modes, with lists larger and smaller > than the view. > > > Thanks, > > Aurélien > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
