----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8253 -----------------------------------------------------------
Since the ToolTipContent is copied in ToolTipManager::setContent anyway, I wouldn't declare it as a member variable, but just allocate a ToolTipContent on the stack as needed. This way, you wouldn't have to introduce a new member variable and could keep the header unchanged. Otherwise, it looks good to me. - Ingomar On 2010-10-19 19:22:04, Sujith H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5660/ > ----------------------------------------------------------- > > (Updated 2010-10-19 19:22:04) > > > Review request for Plasma and Anne-Marie Mahfouf. > > > Summary > ------- > > Added the filename as tooltip for the frame applet. The filename will be > displayed as the > tooltip when the user moves the moves on the frame. > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1187544 > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 > > Diff: http://svn.reviewboard.kde.org/r/5660/diff > > > Testing > ------- > > Tested on the set of pictures I had in my laptop. > > > Thanks, > > Sujith > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
