----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5914/#review8868 -----------------------------------------------------------
/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.h <http://svn.reviewboard.kde.org/r/5914/#comment9503> i think this should be bore adjustedSavedPos() toReal looks more converting to a uhm real :) - Marco On 2010-11-20 19:34:11, Alex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5914/ > ----------------------------------------------------------- > > (Updated 2010-11-20 19:34:11) > > > Review request for Plasma and Marco Martin. > > > Summary > ------- > > Currently we're saving the notifications using absolute positions, because of > this the notification is misplaced if the resolution changes, or the desktop > is extended with another monitor. > > This patch changes the way the position is saved, by doing it measuring the > space between the notification and the screen borders. For example if we > place the notification 10px from bottom and 10px from right, no matters how > the screen configuration changes, it will be always placed 10px bottom 10px > right. > > The only thing left to handle properly is "center" the notification just like > KRunner does, but that will be another patch. > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.h > 1198889 > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.cpp > 1198889 > > Diff: http://svn.reviewboard.kde.org/r/5914/diff > > > Testing > ------- > > I tried to misplace the notification by changing the resolution, > added/removing displays and so far everything has worked well. > > > Thanks, > > Alex > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
