> On 2010-11-28 23:39:49, Aaron Seigo wrote: > > i think the real problem is in KSysGuardProcessList::loadSettings(const > > KConfigGroup &cg) where it uses hard coded defaults such as this line: > > > > setUnits((ProcessModel::Units) cg.readEntry("units", > > (int)ProcessModel::UnitsKB)); > > > > it should be possible to do: > > > > m_processList.setUnits(ProcessModel::UnitsMB); > > m_processList.loadSettings(config); > > > > and have the current settings used as the defaults. the hardcoded defaults > > can be set up in the ctor of KSysGuardProcessList. so the setUnits line > > above would become: > > > > setUnits((ProcessModel::Units) cg.readEntry("units", > > (int)d->m_model.units())); > > > > thoughts?
Yep, makes a lot of sense. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6007/#review9030 ----------------------------------------------------------- On 2010-11-28 23:31:11, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6007/ > ----------------------------------------------------------- > > (Updated 2010-11-28 23:31:11) > > > Review request for Plasma, Aaron Seigo and John Tapsell. > > > Summary > ------- > > The KSystemActivityDialog uses MB as default unit. > BUG:222022 > > > This addresses bug 222022. > https://bugs.kde.org/show_bug.cgi?id=222022 > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/krunner/ksystemactivitydialog.cpp 1201754 > > Diff: http://svn.reviewboard.kde.org/r/6007/diff > > > Testing > ------- > > > Thanks, > > Matthias > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel