> On 2010-12-01 18:29:33, Aaron Seigo wrote:
> > make sense :)

Thanks, applied.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6020/#review9081
-----------------------------------------------------------


On 2010-12-01 17:06:19, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6020/
> -----------------------------------------------------------
> 
> (Updated 2010-12-01 17:06:19)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> In some situations (KPackageKit KSNI comes to mind), the KSNI is deleted when 
> the user right clicks it. While the behavior of that application is 
> questionable, it should not crash the workspace.
> 
> The change here ensures that the menu is showing asynchronously. It prevents 
> a random crash which I uncovered after fixing the original issue of bug 
> #241562 (see http://reviewboard.kde.org/r/6022/ )
> 
> 
> This addresses bug 241562.
>     https://bugs.kde.org/show_bug.cgi?id=241562
> 
> 
> Diffs
> -----
> 
>   
> trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.cpp
>  1201811 
> 
> Diff: http://svn.reviewboard.kde.org/r/6020/diff
> 
> 
> Testing
> -------
> 
> Right-clicking KPackageKit KSNI would cause a crash one time out of three 
> before this patch. It does not crash anymore now.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to