----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6338/#review9639 -----------------------------------------------------------
some code style issues, but otherwise looks good. /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp <http://svn.reviewboard.kde.org/r/6338/#comment10664> these should go at the top of the file with the other includes. preferably using the CamelCase style, e.g. #include <KMimeType> /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp <http://svn.reviewboard.kde.org/r/6338/#comment10665> no spaces before/after ()s /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp <http://svn.reviewboard.kde.org/r/6338/#comment10666> whitespace /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp <http://svn.reviewboard.kde.org/r/6338/#comment10667> whitespace after (s and before )s should be removed - Aaron On Jan. 16, 2011, 9:47 a.m., Amir Pakdel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6338/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2011, 9:47 a.m.) > > > Review request for Plasma, Sebastian Trueg and Vishesh Handa. > > > Summary > ------- > > I have changed NepomukSearchRunner a little bit, so I could search for > contents of notes (added by BasketNotepad) using KRunner. > > It uses NIE:mimeType of the resource to set the "type" and "iconName" of the > search result. If the resourse does not have NIE:mimeType property, > KMimeType::findByUrl(url) is used instead (in order to find the mime-type > associated with the url of the resource). > > When running/opening the search result, preferredService of the mime-type is > used in invokation of KRun::run; therefore, the mime-type of the resource (or > its url) indicates the service that would be used to run the resource. > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp > 1193800 > > /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp > 1193800 > > Diff: http://svn.reviewboard.kde.org/r/6338/diff > > > Testing > ------- > > I have searched for contents of notes that were added by BasketNotepad (using > KRunner) and opened them in BasketNotepads. > > > Thanks, > > Amir > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
