----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6375/#review9658 -----------------------------------------------------------
Ship it! just needs apidox. trunk/KDE/kdelibs/plasma/wallpaper.h <http://svn.reviewboard.kde.org/r/6375/#comment10728> will need API documentation before committing. trunk/KDE/kdelibs/plasma/wallpaper.h <http://svn.reviewboard.kde.org/r/6375/#comment10729> needs apidox; should include a bit about how in libplasma2/KDE5 this will be merged with setUrls and be made a virtual method. will need an @since 4.7 in there too :) - Aaron On Jan. 20, 2011, 5:44 p.m., Sinny Kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6375/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2011, 5:44 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > According to suggestion given by Aaron (refer to mailing list thread > http://mail.kde.org/pipermail/plasma-devel/2011-January/014610.html ), I have > done changes in trunk/KDE/kdelibs/plasma/. I have added functions > setUrls(const KUrl::List &urls) as public function and addUrls(const > KUrl::List &urls) as protected Q_SLOTS in it so that setUrls() can be invoked > from frame applet. There are more patches to come, after this one gets > approved. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/wallpaper.h 1215563 > trunk/KDE/kdelibs/plasma/wallpaper.cpp 1215563 > > Diff: http://svn.reviewboard.kde.org/r/6375/diff > > > Testing > ------- > > Tested in trunk and everything is working fine. > > > Thanks, > > Sinny > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
