----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100576/#review1295 -----------------------------------------------------------
Ship it! consistency ftw. one thing: when m_useCustomColor changes value to true, the svg file should probably be deleted. - Aaron J. On Feb. 5, 2011, 3:44 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100576/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2011, 3:44 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Summary > ------- > > use a svg textre to paint the clock text (and one of its shadow) if a custom > font color is not chosen, to have a style as coherent as possible with the > systray icons > > > Diffs > ----- > > plasma/generic/applets/digital-clock/clock.h > cdbd0a4963adac6e79eaf5f4f28de1f61d14af77 > plasma/generic/applets/digital-clock/clock.cpp > 672eaabd82310d5b0a5d5ef901a00a1771c6bc2f > > Diff: http://git.reviewboard.kde.org/r/100576/diff > > > Testing > ------- > > still some rendering glitches in the Plasma::Paintutils function, but should > be easily fixable > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/100576/s/72/ > > http://git.reviewboard.kde.org/r/100576/s/73/ > > > Thanks, > > Marco > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
