> On Feb. 8, 2011, 7 p.m., Anne-Marie Mahfouf wrote: > > Reviewed. The only missing thing was when you cleared the combo field and > > wrote your own element and if you use > > connect(ui.elementCombo, SIGNAL(editTextChanged(QString)), parent, > > SLOT(settingsModified())); > > it'll work (instead of the currentIndexCHanged signal)
Another comment: the connect lines should be at the end of the code in the createConfigurationInterface(KConfigDialog *parent) method in order to have Apply disabled when opening the dialog (as nothing has been changed yet). - Anne-Marie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100609/#review1314 ----------------------------------------------------------- On Feb. 8, 2011, 5:26 p.m., Sinny Kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100609/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2011, 5:26 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Enabled "Apply" button in webslice configuration dialog > > > Diffs > ----- > > applets/webslice/plasma/webslice.cpp 08e40a0 > > Diff: http://git.reviewboard.kde.org/r/100609/diff > > > Testing > ------- > > works fine in trunk > > > Thanks, > > Sinny > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel