> On Feb. 7, 2011, 9:30 p.m., Aaron J. Seigo wrote: > > nice :)
okay, so umm I was wondering if this should or should not be backported to KDE/4.6? - Lasse ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100589/#review1301 ----------------------------------------------------------- On Feb. 7, 2011, 8:26 p.m., Lasse Liehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100589/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2011, 8:26 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > The condition icons didn't always show up correctly because i18n'd condition > strings were passed to getConditionIcon(). This tries to fix it, passing it > the original strings. > > > Diffs > ----- > > plasma/generic/dataengines/weather/ions/noaa/ion_noaa.h 84e8d6f > plasma/generic/dataengines/weather/ions/noaa/ion_noaa.cpp 4987968 > > Diff: http://git.reviewboard.kde.org/r/100589/diff > > > Testing > ------- > > The correct icons are used on the summary (tested during both day and night) > and forecasts, using the "weather" applet and Finnish. The conditions in > forecasts' tooltips are still translated. > > > Thanks, > > Lasse > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
