-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101247/
-----------------------------------------------------------

Review request for Plasma and Petri Damstén.


Summary
-------

This patch fixes compilation when GPSD_API_MAJOR_VERSION >= 5. The API has 
changed and some calls are not compatible with the previous versions. GPSD 
version here: 2.96.


Diffs
-----

  plasma/generic/dataengines/geolocation/location_gps.h 506d1d1 
  plasma/generic/dataengines/geolocation/location_gps.cpp c44cb30 

Diff: http://git.reviewboard.kde.org/r/101247/diff


Testing
-------

I wasn't able to compile the geolocation dataengine, while applying this patch 
I can. I have only tested with my GPSD version (2.96), haven't tested with 
previous versions, however it should work, since for previous versions the 
calls made are exactly the same as before this patch. Not even unused arguments 
are created.


Thanks,

Rafael Fernández

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to