----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101252/#review2957 -----------------------------------------------------------
we discussed this and decided we really don't like the '*' :) instead, we'd like to see a TabBar::highlightTab(int index, bool highlight) and bool TabBar::isTabHighlighted(int index) const and have TabBar decide what that means (it could be colourized, e.g.) but we don't want to give too much access to app devels as to _how_ it is highlighted. would you be interested in trying a patch that does this? - Aaron J. On April 29, 2011, 8:26 a.m., Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101252/ > ----------------------------------------------------------- > > (Updated April 29, 2011, 8:26 a.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Summary > ------- > > Checks if there a new comic strips for the chosen comics. The user can define > a time intervall in minutes for that. > If a new comic strip is found, then the tab is "highlighted" by prepending a > "*" to the tab text. > First I planned to change the tab text color but this is not possible, unless > the NativeTabBar code would change. > But I think the way it is now works reasonable well. > > > Diffs > ----- > > applets/comic/comic.h 7134c72 > applets/comic/advancedsettings.ui 0d4bde9 > applets/comic/comic.cpp 88a2e31 > applets/comic/comicSettings.ui 497ffbb > applets/comic/configwidget.h ffc7618 > applets/comic/configwidget.cpp d9078d8 > > Diff: http://git.reviewboard.kde.org/r/101252/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/101252/s/142/ > > http://git.reviewboard.kde.org/r/101252/s/143/ > > > Thanks, > > Matthias > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
