-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102118/
-----------------------------------------------------------
(Updated July 28, 2011, 4:46 p.m.)
Review request for Plasma and Aaron J. Seigo.
Summary (updated)
-------
If there are multiple screens with different resolutions or which
are not alligned the same way then it could happen that popups at
the edge were drawn (partially) offscreen.
This patch fixes that issue.
I have the feeling that the code in this method is really ugly, I wonder if
there are plans to refactor it or to clean it up?
NOTE: I don't know if this patch might cause problems if there are animations
that are supposed to start offscreen etc. So please you with more insight look
at the patch to see if there could be some negative side effects.
====
I just realised that the real problem is most likely that the existing code
assumes that the screen begins at 0,0 e.g:
default:
if (pos.y() - s.height() > 0) {//if 0 was replaced with
screenRect.top() it would also work in the specific case described in the report
pos.ry() = pos.y() - s.height();
} else {
pos.ry() = pos.y() +
(int)actualItem->boundingRect().size().height() + 1;
}
This addresses bug 276336.
http://bugs.kde.org/show_bug.cgi?id=276336
Diffs
-----
plasma/corona.cpp 4afef7b
Diff: http://git.reviewboard.kde.org/r/102118/diff
Testing
-------
Thanks,
Matthias
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
