----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102357/#review5785 -----------------------------------------------------------
editors/editpage.cpp <http://git.reviewboard.kde.org/r/102357/#comment5117> more indentation oddness ... it should also probably check to see if the file doesn't already have an extension; it may be completely correct that the user enters in something like "foobar.js" in a QML project, for instance. - Aaron J. On Aug. 17, 2011, 7:42 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102357/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2011, 7:42 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Hello > > If you open the "files" toolbar and you try to add something new with the > "New.." in the executable scripts, then if you don't add the .{qml,js,rb,py}, > then the file will be saved without the mimetype extension. This patch is > fixing this issue.If you don't like something into the names which i gave, > then let me know :) > > > Diffs > ----- > > editors/editpage.cpp d4b0082 > packagemodel.h a14033c > packagemodel.cpp 8c0907a > > Diff: http://git.reviewboard.kde.org/r/102357/diff > > > Testing > ------- > > plasmate compiles fine. New files can be added into the other menus, without > any issue. > > > Thanks, > > Antonis > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
