> On Nov. 2, 2011, 9:58 p.m., Christoph Feck wrote: > > plasma/declarativeimports/qtextracomponents/qiconitem.cpp, line 37 > > <http://git.reviewboard.kde.org/r/103009/diff/2/?file=40071#file40071line37> > > > > Is there any specific reason why this isn't "const QVariant &icon"? All > > used QVariant methods are const.
fixed and pushed. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/#review7884 ----------------------------------------------------------- On Nov. 1, 2011, 6:43 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103009/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2011, 6:43 p.m.) > > > Review request for KDE Runtime and Plasma. > > > Description > ------- > > Hi, > > I found it very strange that QIcon::fromTheme was "just working". Sadly in > KDE's brand new PlasmaComponents it was simply impossible to use the system > icons without using plasma to view the QML. This patch adds a property to > QIconItem named: "fromTheme" which allows you to get the icons from the theme > you currently use. This patch alone isn't helping a lot of people but i have > a second patch ready for PlasmaComponents.Button to make use of this. > > Oke to commit? > > > Diffs > ----- > > plasma/declarativeimports/qtextracomponents/qiconitem.h 9972a98 > plasma/declarativeimports/qtextracomponents/qiconitem.cpp d72381e > > Diff: http://git.reviewboard.kde.org/r/103009/diff/diff > > > Testing > ------- > > Tested it with a bunch of different icons in and it all just seems to work > fine. > > > Thanks, > > Mark Gaiser > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
