----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8754 -----------------------------------------------------------
applets/qalculate/qalculate_applet.cpp <http://git.reviewboard.kde.org/r/103052/#comment7346> this looks wrong. it should be put into a layout somewhere and managed that way. in particular, this will break with larger fonts. applets/qalculate/qalculate_applet.cpp <http://git.reviewboard.kde.org/r/103052/#comment7347> if this is to make m_output appear before m_historyButton in the layout, use insertItem instead of addItem :) - Aaron J. Seigo On Nov. 11, 2011, 5:41 p.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103052/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2011, 5:41 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Hey dudes, > I implemented a little menu that displays the last 10 results. improvement > ideas? > > I found this task in the plasma task list: > http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid > > > Diffs > ----- > > applets/qalculate/qalculate_applet.h aee14c0 > applets/qalculate/qalculate_applet.cpp 4da9241 > applets/qalculate/qalculate_history.h 59185ee > applets/qalculate/qalculate_history.cpp 35592a7 > > Diff: http://git.reviewboard.kde.org/r/103052/diff/diff > > > Testing > ------- > > seems to work > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
