----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review8892 -----------------------------------------------------------
nice :) this has been needed for some time and indeed causes stalls for some people. what's still missing from this is connecting to Solid::Networking::notifier()'s shouldConnect() call to bring up the listing when the network becomes available. great start though :) plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/103393/#comment7407> this needs to be indented properly. also, instead of a knotification, which will appear somewhere unrelated, try using the setMessage method that comes with Plasma::Applet - Aaron J. Seigo On Dec. 12, 2011, 3:40 p.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103393/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2011, 3:40 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Adding patch for the TODO, mentioned in the folderview.cpp file. This patch > looks whether the url is local or remote. If its remote then checks for the > network status of the host machine. If the host machine is not connected to > the network then returns. > > > Diffs > ----- > > plasma/applets/folderview/folderview.cpp 43d0511 > > Diff: http://git.reviewboard.kde.org/r/103393/diff/diff > > > Testing > ------- > > Tested by removing the host from the network and by adding the host to the > network. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
