----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/ -----------------------------------------------------------
(Updated Dec. 19, 2011, 2:03 p.m.) Review request for kdelibs and Plasma. Changes ------- Use patch http://git.reviewboard.kde.org/r/103469 (against kdelibs). This patch is trivial now, if review 103469 is approved I will commit this one as well since kde-workspace will not compile with this one applied and without patch 103469 applied against kdelibs. Description ------- The patch resets time format in digital clock plasmoid when the user changes the 24h configuration in active-settings. The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am wondering if I should add this change to kdelibs instead of kde-workspace to avoid duplicating code. Anyway, I wanted someone to review the code to see if there can be any side effect. This addresses bug 289094. http://bugs.kde.org/show_bug.cgi?id=289094 Diffs (updated) ----- plasma/generic/applets/digital-clock/clock.h 4aec3fd plasma/generic/applets/digital-clock/clock.cpp dd03692 Diff: http://git.reviewboard.kde.org/r/103434/diff/diff Testing ------- Works in Plasma Active. In Plasma Desktop kcmlocale does not call KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it does not take effect. Other kcm modules (e.g. keyboard), call emitChange. Thanks, Lamarque Vieira Souza
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
