----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103595/#review9391 -----------------------------------------------------------
This review has been submitted with commit 1b7bc69d6d78e6a82b5664f1922a56563a1fe0f4 by Nikita Churaev to branch KDE/4.8. - Commit Hook On Dec. 31, 2011, 5:18 a.m., Nikita Churaev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103595/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2011, 5:18 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Right-aligned popups are one pixel away from right edge of the screen and > top-aligned popups (when the panel is on top) are one pixel inside panel. > This is because the bug in QRect, where right() and bottom() value return > value that is less than the true value by one. This is a feature-bug that Qt > developers aren't going to fix because of compatiability reasons. My patch > replaces rect.right() and rect.bottom() with (rect.x() + rect.width()) and > (rect.y() + rect.height()) respectively. > > > Diffs > ----- > > plasma/corona.cpp 366a9df > > Diff: http://git.reviewboard.kde.org/r/103595/diff/diff > > > Testing > ------- > > Works as expected. > > > Thanks, > > Nikita Churaev > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
