----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103632/ -----------------------------------------------------------
Review request for Plasma and Ivan Čukić. Description ------- I am wondering what I am missing that I seem to be the only one to have hit this so far, but currently kde-workspace (at least master) does not build completely for me because the symbols from libkactivities.so are missing for anything linking against it. The reason is for me that FindKActivities.cmake sets the var "KACTIVITIES_LIBS", but everywhere in the CMakeLists.txt "KACTIVITIES_LIBRARY" used, resulting in an empty string added to the libs to link to ? fail. Attached patch fixes this. Okay to commit? Diffs ----- plasma/generic/dataengines/activities/CMakeLists.txt a954c2a plasma/generic/runners/activities/CMakeLists.txt e630c36 powerdevil/daemon/CMakeLists.txt 35a4fd4 powerdevil/kcmodule/activities/CMakeLists.txt a360f30 kwin/CMakeLists.txt 1fb4d76 libs/taskmanager/CMakeLists.txt 375a0d6 plasma/desktop/applets/pager/CMakeLists.txt 056f9d4 plasma/desktop/shell/CMakeLists.txt e0b9a26 Diff: http://git.reviewboard.kde.org/r/103632/diff/diff Testing ------- Applied the patch and kde-workspace builds completely for me and plasma-desktop & co. runs fine Thanks, Friedrich W. H. Kossebau
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
