----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103564/#review9742 -----------------------------------------------------------
Ship it! other than getting rid of the magic value, looks good! switch this to use KDialog::marginHint() and commit. thanks. plasma/desktop/shell/dashboardview.cpp <http://git.reviewboard.kde.org/r/103564/#comment8044> where does the magic 13 come from? should probably be using the static int KDialog::marginHint() .. - Aaron J. Seigo On Dec. 28, 2011, 12:56 p.m., Reza Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103564/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2011, 12:56 p.m.) > > > Review request for Plasma. > > > Description > ------- > > I have added little margin to widget explorer invoked from dashboard view. > > > Diffs > ----- > > plasma/desktop/shell/dashboardview.cpp 0ac06ab > > Diff: http://git.reviewboard.kde.org/r/103564/diff/diff > > > Testing > ------- > > Tested against master, and seems worked well > > > Screenshots > ----------- > > widgetexplorer_in_dashboard > http://git.reviewboard.kde.org/r/103564/s/385/ > > > Thanks, > > Reza Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
